[db/mssql] Fix db.type property value for metrics#1914
Closed
sincejune wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
[db/mssql] Fix db.type property value for metrics#1914sincejune wants to merge 1 commit intoopen-telemetry:mainfrom
sincejune wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
3 tasks
trask
reviewed
Feb 18, 2025
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
hi @sincejune! if you have time would you mind also updating the other locations of
db.systemMUST be set to ...
Contributor
Author
Raised #1917 for renaming |
arminru
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes mandatory value for mssql
db.typeproperty in metrics tomicrosoft.sql_serverto be consistent with spans. ref: https://opentelemetry.io/docs/specs/semconv/database/mssql/#spansNote: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]